#991 ux improvements: OIDC Login Label - #1022
Open
DerDummePunkt wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 74.63% 74.78% +0.14%
==========================================
Files 66 66
Lines 3532 3541 +9
==========================================
+ Hits 2636 2648 +12
+ Misses 690 688 -2
+ Partials 206 205 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DerDummePunkt
force-pushed
the
github_991_ux_improvments_configurable_oidc_login_button_text
branch
from
August 14, 2026 07:46
5f23372 to
4b2fa6a
Compare
used project formatting tools to (hopefully) resolve automated checks
i dont know which tool added that, but now the CI seems to fail becuase of it. seems a bit odd that i have to commit stuff before the CI spits out reproduceable results.
defintiion to have line breaks is what causes the line by line coverage rate to drop below the threshold. added new router test for /gotifyinfo to rectify that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #991
adds env var GOTIFY_OIDC_IDP_NAME with default "OIDC"
variable is used in the UI for button labels at login and elevation forms
Few notes here:
I decided to name the new env var
GOTIFY_OIDC_IDP_NAME, since the value is used for both the login button label as well as the label of the elevation form button. Let me know if you want that variable name changed.I wasnt really sure what tests to add here. I could have written something like
in
config/config_test.go, but all that would guard against is that the env variable nameGOTIFY_OIDC_IDP_NAMEdoesnt change in thekeys.go, pretty useless imhoI havent added any length limit/check yet, I say, if some poor soul wants to put the combined works of Williams Shakespear into that button, let them. Values longer than a few chars cause a line break in the button, personally I think that still looks fine, still, if you want some arbitrary limit on that, let me know.